|
Poznámky k chybe |
michal
2004-02-10 17:49
|
partial implementation could be done with cgi_vars prefixing (it's almost at the same place)
could you give a link to some good documentation or a nice working example ? |
|
|
hbernard
2004-02-10 19:09
|
I'll try to post a pme-sample at the end of the week, but see http://www.csszengarden.com/ for sample use of css |
|
|
michal
2004-02-11 21:34
|
now you've made me a big css fan. good bye table designs ....
i see all of the stuff is made with div-s. does it also work with td-s ? |
|
|
hbernard
2004-02-23 18:18
|
yes, it would work with td-s.
In a perfect world, starting from scratch with no user base, we would generate div and use great css class. But this is OK to use valid xml with td-s. |
|
|
ajh
2004-04-13 17:02
|
My vote is for:
pme_id_<fieldname>
But that's because I've already used that in the new htmlcal extension. Once the final decision is taken I'll update the extension. |
|
|
hbernard
2004-04-21 11:52
|
API could be :
$opts['css']['id_prefix'] = 'cssidprefix:'; (default : 'PME::id::')
$opts['fdd']['myfield']['css']['id'] = 'mycustomid']
then HTML output would be
for a field => id = 'PME::id::myfield' or (if customized) 'cssidprefix:mucsutomid'
for tabs => id = 'PME::id::tab0'
etc ...
Nepto, what do you think ? Current 'id' is fixed only for 'tab' purpose, but I think this would be easy to extend, no ?
AND, 'id' could be a customizable button properties (via button order bug) |
|
|
michal
2004-04-21 14:46
|
do we also need id for 'name' and 'help' (i see only 'value' discussed) ? i guess they cannot have the same name ... |
|
|
hbernard
2004-04-21 14:58
|
oups, you're right, we have to be able to name all tags.
something like (for fields)
<PME prefix id><name|value|help>::<field_name>
and (for positioned (up/down) elements)
<PME prefix id><button|tab>::<position>::<element id>
with element id be savedelete,applychange,... for buttons, or 0,1,2... for tab
and (for "div" elements like table, row, td, div, etc...
......
Hmm, I need your comments in order not to forget something.
We certainly may use part of css class convention, no ?
edited on: 2004-04-21 15:16 |
|
|
michal
2004-04-21 15:17
|
i guess we leave LF modes as is....
btw is '::' a good separator ? if it's not a special character in js/css/whatever/.... i'm not experienced in this, so excuse my stupid questions ...
and 'field_name' with 'bad' characters ?
looking at the page, 'message', 'timer' (has to be enclosed), some 'hr', ...
what about 'tr' and 'table'(3times) ? id for those also ?
i would prefer <PME prefix id>::<...> (if :: is ok)
i'm looking forward for a nice css style-sheet... |
|
|
hbernard
2004-04-21 15:27
|
1. :: as separator. object oriented separator, valid in 'id', AFAIK.
I speaking of this one because this is what nepto choose for url cgi prefixing.
However, we maybe (certainly) should be consistent with current css style, so use '-'. Yes, we have to go for this. No ?
2. About including or not the separator in the prefix : answer is
yes if we use css global API.
3. yes, there are missing enclosing, need to <SPAN> them.
4. 'tr' and 'table'. Yes, if possible, which means, if this is easy to name.
I think main table should be id-ized, and rows with their according field name also (?), ....
Briefly, all the time there is a good well specified css class, we have to do this. |
|
|
michal
2004-04-21 15:45
|
4. so for 'tr'
<PME prefix id>tr::<field_name>
(field_name is defined as $opts['fdd']['field_name'], i suppose)
i think, there are just three tables: 'top'/'botton' or 'up'/'down' (for buttons) and 'main' (for all contents...)
<PME prefix id>table::main ...
1. well, '-' looks nicer to me, it's already in css
2. since the separator will never be changed (?), it can be hardcode in the prefix |
|
|
hbernard
2004-04-21 16:04
|
1. agreed
2. well, no, http://platon.sk/projects/doc.php/phpMyEdit/html/configuration.css.html
says that there is an API
opts['css']['separator']
So I suggest to use it ;-)
another table is tab, no ?
so we would go with
<pme prefix id><pme css separator>table<pme css separator>main|top|up|down ? |
|
|
michal
2004-04-21 16:45
|
i thing we lost ajh, he needs id for <input ..> so
<pme prefix>-input-<field_name> (no matter whether it's input, select, dropdown, ...)
but we will come into problems on SF modes. there can be two inputs (N select)....
2. ok |
|
|
hbernard
2004-04-21 17:04
|
Another solution is to stick with current css class name
- if this is unique, go with it
- if there are multiple entities with same type of class name,
* - remove the divider section
* - append a postfix (up, down, field name, etc...)
main idea is to use css class name, remove eventually some postfixes, and append required postfixes.Special case for input (like you write it)
With this, I think policy will be much understandable and maintainable.
so :
<form class="pme-form" ... id="pme-form" ... unique form ...
<input type="hidden" name="sfn[0]" ... id="pme-input-sfn[0]"... no class specified + input convention
<table class="pme-navigation"... id = "pme-navigation-table-up"
<tr class="pme-navigation" ... id="pme-navigation-row-up"
... need to have distinct id
<td class="pme-buttons" ... id="pme-buttons-up" ...
<input ... class="pme-save" name="saveadd" ... id="pme-input-saveadd-up"
<hr class="pme-hr" ... id="pme-hr-up"
<table class="pme-tab" ... id="pme-tab-table-up"
<tr class="pme-tab" id="pme-tab-row-up"
<td class="pme-tab-selected" id="pme-tab-label-0-up" ...
<a class="pme-tab-selected" id="pme-tab-link-0-up" ...
...
<div id="pme-tab-div-0">
<table class="pme-main" ... id="pme-main-[tab-0]"
<tr class="pme-row-0" id="pme-row-ID" (ID is the name of the field
<td class="pme-key-0" id="pme-key-ID"
<td class="pme-value-0" id="pme-value-ID"
<input class="pme-input-0" name="ID" id="pme-input-ID"
Something like this. |
|
|
ajh
2004-04-22 09:23
|
I don't think that I'm particularly worried about what the actual name is as long as I can generate the code to access the field id in the relevant javascript.
I guess my only concern is that we don't over engineer this. |
|
|
hbernard
2004-04-22 09:25
|
Sorry, ajh, what do you mean with "over engineer this" ? |
|
|
ajh
2004-04-22 10:09
|
I mean that it needs to be fairly straightforward for a power user to be able to work out what each of IDs are so that they can add scripts or create style sheets without having to dive into the code. It's a balance between coding in every possible combination and keeping it simple enough for most people to be able to use.
Of course, even better would be the ability for PMESetup to be able to generate a sample stylesheet with all of the classes and IDs generated in the document present with default values for the user to just edit....hmm...maybe that's a job to do on a long day :-) |
|
|
michal
2004-04-22 19:10
|
hbernard, your proposal on names makes sense. we would probably get to it anyway, but it would be a hard hard way :) |
|
|
|
História chýb |
|
Dátum poslednej úpravy |
Používateľské meno |
Pole |
Zmeniť |
|
2004-02-02 10:30 |
hbernard |
Nová chyba |
|
|
2004-02-02 11:06 |
hbernard |
Chyba monitorovaná: hbernard |
|
|
2004-02-10 17:49 |
michal |
Poznámka k chybe pridaná: 0000704 |
|
|
2004-02-10 19:09 |
hbernard |
status |
nový => reakcia |
|
2004-02-10 19:09 |
hbernard |
Poznámka k chybe pridaná: 0000705 |
|
|
2004-02-11 21:34 |
michal |
Poznámka k chybe pridaná: 0000707 |
|
|
2004-02-23 18:18 |
hbernard |
Poznámka k chybe pridaná: 0000739 |
|
|
2004-04-13 17:02 |
ajh |
Poznámka k chybe pridaná: 0000921 |
|
|
2004-04-21 11:52 |
hbernard |
Poznámka k chybe pridaná: 0001048 |
|
|
2004-04-21 14:46 |
michal |
Poznámka k chybe pridaná: 0001052 |
|
|
2004-04-21 14:58 |
hbernard |
Poznámka k chybe pridaná: 0001053 |
|
|
2004-04-21 15:16 |
hbernard |
Poznámka k chybe upravená: 1053 |
|
|
2004-04-21 15:17 |
michal |
Poznámka k chybe pridaná: 0001057 |
|
|
2004-04-21 15:27 |
hbernard |
Poznámka k chybe pridaná: 0001059 |
|
|
2004-04-21 15:45 |
michal |
Poznámka k chybe pridaná: 0001061 |
|
|
2004-04-21 16:04 |
hbernard |
Poznámka k chybe pridaná: 0001062 |
|
|
2004-04-21 16:45 |
michal |
Poznámka k chybe pridaná: 0001064 |
|
|
2004-04-21 17:04 |
hbernard |
Poznámka k chybe pridaná: 0001065 |
|
|
2004-04-22 09:23 |
ajh |
Poznámka k chybe pridaná: 0001069 |
|
|
2004-04-22 09:25 |
hbernard |
Poznámka k chybe pridaná: 0001070 |
|
|
2004-04-22 10:09 |
ajh |
Poznámka k chybe pridaná: 0001071 |
|
|
2004-04-22 19:10 |
michal |
Poznámka k chybe pridaná: 0001088 |
|
Prihlásiť
Registrácia
English
